devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix various compiler warnings

Browse Source 
libeigen/eigen!2072
This commit is contained in:
Charles Schlosser
2025-11-10 17:14:35 +00:00
committed by Rasmus Munk Larsen
parent 8ae3b1aaa5
commit 1133aa82c7
4 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Eigen/src/SVD/JacobiSVD.h
View File

@@ -720,6 +720,7 @@ JacobiSVD<MatrixType, Options>& JacobiSVD<MatrixType, Options>::compute_impl(con
m_isInitialized = true;
m_info = InvalidInput;
m_nonzeroSingularValues = 0;
m_singularValues.setZero();
return *this;
}
if (numext::is_exactly_zero(scale)) scale = RealScalar(1);

6
test/rand.cpp
View File

@@ -30,12 +30,10 @@ EIGEN_DONT_INLINE Scalar check_in_range(Scalar x, Scalar y) {
template <typename Scalar>
void check_all_in_range(Scalar x, Scalar y) {
constexpr int repeats = 32;
uint64_t count = static_cast<uint64_t>(y) - static_cast<uint64_t>(x) + 1;
Index count = static_cast<Index>(y) - static_cast<Index>(x) + 1;
ArrayX<bool> mask(count);
// ensure that `count` does not overflow the return type of `mask.size()`
VERIFY(count == static_cast<uint64_t>(mask.size()));
mask.setConstant(false);
for (uint64_t k = 0; k < count; k++)
for (Index k = 0; k < count; k++)
for (int repeat = 0; repeat < repeats; repeat++) {
Scalar r = check_in_range(x, y);
Index i = static_cast<Index>(r) - static_cast<Index>(x);

2
test/threads_fork_join.cpp
View File

@@ -26,7 +26,7 @@ static void test_parallel_for(int granularity) {
TestData test_data = make_test_data(/*num_threads=*/4, kNumTasks);
std::atomic<uint64_t> sum(0);
std::function<void(Index, Index)> binary_do_fn = [&](Index i, Index j) {
for (int k = i; k < j; ++k)
for (Index k = i; k < j; ++k)
for (uint64_t new_sum = sum; !sum.compare_exchange_weak(new_sum, new_sum + test_data.data[k]);) {
};
};

12
unsupported/test/cxx11_tensor_expr.cpp
View File

@@ -312,6 +312,9 @@ static void test_select() {
}
}
// Nan propagation does currently not work like one would expect from std::max/std::min,
// so we disable it for now
#if !EIGEN_ARCH_ARM_OR_ARM64
template <typename Scalar>
void test_minmax_nan_propagation_templ() {
for (int size = 1; size < 17; ++size) {
@@ -430,6 +433,10 @@ void test_minmax_nan_propagation_templ() {
VERIFY_IS_EQUAL(val(), (size == 1 ? -kInf : kZero));
}
}
#else
template <typename Scalar>
void test_minmax_nan_propagation_templ()
#endif
static void test_clip() {
Tensor<float, 1> vec(6);
@@ -465,10 +472,5 @@ EIGEN_DECLARE_TEST(cxx11_tensor_expr) {
CALL_SUBTEST(test_type_casting());
CALL_SUBTEST(test_select());
CALL_SUBTEST(test_clip());
// Nan propagation does currently not work like one would expect from std::max/std::min,
// so we disable it for now
#if !EIGEN_ARCH_ARM_OR_ARM64
CALL_SUBTEST(test_minmax_nan_propagation());
#endif
}