Rasmus Munk Larsen
1dcae7cefc
Revert "BDCSVD fix -Wmaybe-uninitialized"
...
This reverts merge request !1649
2024-08-05 18:17:01 +00:00
Mike Taves
c593e9e948
Fix typos
2024-08-02 00:06:24 +00:00
Charles Schlosser
3f06651fd6
BDCSVD fix -Wmaybe-uninitialized
2024-07-30 22:53:06 +00:00
Frédéric Chapoton
6331da95eb
fixing a lot of typos
2024-07-30 22:15:49 +00:00
Tyler Veness
d165c7377f
Format EIGEN_STATIC_ASSERT() as a statement macro
2024-05-20 23:02:42 +00:00
Antonio Sánchez
a962a27594
Fix MSVC GPU build.
2024-02-27 23:26:06 +00:00
Charles Schlosser
960892ca13
JacobiSVD: get rid of m_scaledMatrix, m_adjoint, hopefully fix some compiler warnings
2024-02-17 03:41:55 +00:00
Antonio Sánchez
500a3602f0
Use traits<Matrix>::Options instead of Matrix::Options.
2024-02-16 00:11:57 +00:00
Antonio Sánchez
0b9ca1159b
Fix deflation in BDCSVD.
2024-02-15 23:53:59 +00:00
Tobias Wood
f38e16c193
Apply clang-format
2023-11-29 11:12:48 +00:00
Antonio Sánchez
6e4d5d4832
Add IWYU private pragmas to internal headers.
2023-08-21 16:25:22 +00:00
Antonio Sánchez
2af700aa40
Fix nullptr dereference in SVD.
2023-08-01 16:33:16 +00:00
Charles Schlosser
9995c3da6f
Fix -Wmaybe-uninitialized in SVD
2023-07-25 22:22:17 +00:00
Charles Schlosser
1a2bfca8f0
Fix annoying warnings
2023-07-07 20:19:58 +00:00
Charles Schlosser
7d9bb90f15
SVD: fix numerous compiler warnings / failures
2023-05-15 16:56:47 +00:00
Charles Schlosser
fdc749de2a
JacobiSVD: set m_nonzeroSingularValues to zero if not finite
2023-05-02 17:48:21 +00:00
Melven Roehrig-Zoellner
273f803846
Add BDCSVD_LAPACKE binding
2022-12-09 18:50:12 +00:00
Antonio Sánchez
e5794873cb
Replace assert with eigen_assert.
2022-10-04 17:11:23 +00:00
Arthur
27367017bd
Disable bad "deprecated warning" edge-case in BDCSVD
2022-08-11 18:43:31 +00:00
Arthur
705ae70646
Add R-Bidiagonalization step to BDCSVD
2022-05-27 02:00:24 +00:00
Antonio Sanchez
481a4a8c31
Fix BDCSVD condition for failing with numerical issue.
2022-05-20 08:18:31 -07:00
Antonio Sánchez
028ab12586
Prevent BDCSVD crash caused by index out of bounds.
2022-05-19 22:29:48 +00:00
Tobias Schlüter
40eb34bc5d
Fix RowMajorBit <-> RowMajor mixup.
2022-03-17 15:28:12 +00:00
Erik Schultheis
421cbf0866
Replace Eigen type metaprogramming with corresponding std types and make use of alias templates
2022-03-16 16:43:40 +00:00
Tobias Schlüter
cd2ba9d03e
Add construct_at, destroy_at wrappers. Use throughout.
2022-03-08 20:43:22 +00:00
Arthur
c9ff739af1
Fix JacobiSVD_LAPACKE bindings
2022-03-03 19:24:07 +00:00
Antonio Sánchez
b48922cb5c
Fix SVD for MSVC+CUDA.
2022-03-01 21:35:22 +00:00
Antonio Sánchez
f03df0df53
Fix SVD for MSVC.
2022-02-28 19:53:15 +00:00
Arthur
cd80e04ab7
Add assert for edge case if Thin U Requested at runtime
2022-02-23 05:35:19 +00:00
Antonio Sánchez
58a90c7463
Use fixed-sized U/V for fixed-sized inputs.
2022-02-16 18:31:47 +00:00
Antonio Sánchez
766087329e
Re-add svd::compute(Matrix, options) method to avoid breaking external projects.
2022-02-16 00:54:02 +00:00
Arthur
18b50458b6
Update SVD Module with Options template parameter
2022-02-02 00:15:44 +00:00
Erik Schultheis
d271a7d545
reduce float warnings (comparisons and implicit conversions)
2022-01-26 18:16:19 +00:00
Erik Schultheis
c20e908ebc
turn some macros intro constexpr functions
2021-12-10 19:27:01 +00:00
Rasmus Munk Larsen
085c2fc5d5
Revert "Update SVD Module to allow specifying computation options with a...
2021-11-30 18:45:54 +00:00
Arthur
eef33946b7
Update SVD Module to allow specifying computation options with a template parameter. Resolves #2051
2021-11-29 20:50:46 +00:00
Xinle Liu
478a1bdda6
Fix total deflation issue in BDCSVD, when & only when M is already diagonal.
2021-11-02 16:53:55 +00:00
sciencewhiz
4b6036e276
fix various typos
2021-09-22 16:15:06 +00:00
Rasmus Munk Larsen
6cadab6896
Clean up EIGEN_STATIC_ASSERT to only use standard c++11 static_assert.
2021-09-16 20:43:54 +00:00
Rasmus Munk Larsen
d7d0bf832d
Issue an error in case of direct inclusion of internal headers.
2021-09-10 19:12:26 +00:00
Alexander Karatarakis
4ba872bd75
Avoid leading underscore followed by cap in template identifiers
2021-08-04 22:41:52 +00:00
arthurfeeney
a77638387d
Fixes #1387 for compilation error in JacobiSVD with HouseholderQRPreconditioner that occurs when input is a compile-time row vector.
2021-07-20 20:11:22 +00:00
Rasmus Munk Larsen
13fb5ab92c
Fix more enum arithmetic.
2021-06-15 09:09:31 -07:00
Rasmus Munk Larsen
3ddc0974ce
Fix two bugs in commit
2021-04-02 22:06:27 +00:00
Rasmus Munk Larsen
5bbc9cea93
Add an info() method to the SVDBase class to make it possible to tell the user that the computation failed, possibly due to invalid input.
...
Make Jacobi and divide-and-conquer fail fast and return info() == InvalidInput if the matrix contains NaN or +/-Inf.
2021-03-31 21:09:19 +00:00
Antonio Sanchez
66841ea070
Enable bdcsvd on host.
...
Currently if compiled by NVCC, the `MatrixBase::bdcSvd()` implementation
is skipped, leading to a linker error. This prevents it from running on
the host as well.
Seems it was disabled 6 years ago (5384e891 ) to match `jacobiSvd`, but
`jacobiSvd` is now enabled on host. Tested and runs fine on host, but
will not compile/run for device (though it's not labelled as a device
function, so this should be fine).
Fixes #2139
2021-02-08 12:56:23 -08:00
Christoph Hertzberg
ac21a08c13
Cast Index to RealScalar
...
This fixes compilation issues with RealScalar types that are not implicitly castable from Index (e.g. ceres Jet types).
Reported by Peter Anderson-Sprecher via eMail
2019-05-23 15:31:12 +02:00
Gael Guennebaud
45e65fbb77
bug #1695 : fix a numerical robustness issue. Computing the secular equation at the middle range without a shift might give a wrong sign.
2019-03-27 20:16:58 +01:00
Christoph Hertzberg
da0a41b9ce
Mask unused-parameter warnings, when building with NDEBUG
2019-01-18 10:41:14 +01:00
Patrick Peltzer
15e53d5d93
PR 567: makes all dense solvers inherit SoverBase (LU,Cholesky,QR,SVD).
...
This changeset also includes:
* add HouseholderSequence::conjugateIf
* define int as the StorageIndex type for all dense solvers
* dedicated unit tests, including assertion checking
* _check_solve_assertion(): this method can be implemented in derived solver classes to implement custom checks
* CompleteOrthogonalDecompositions: add applyZOnTheLeftInPlace, fix scalar type in applyZAdjointOnTheLeftInPlace(), add missing assertions
* Cholesky: add missing assertions
* FullPivHouseholderQR: Corrected Scalar type in _solve_impl()
* BDCSVD: Unambiguous return type for ternary operator
* SVDBase: Corrected Scalar type in _solve_impl()
2019-01-17 01:17:39 +01:00