1) remove EIGEN_UNUSED, instead use non-named arguments.

2) use T instead of const T& when that makes more sense
Thanks to Christian Mayer a.k.a Mekhzolan for the tips.
This commit is contained in:
Benoit Jacob
2007-12-11 15:25:43 +00:00
parent 0cbdaf6bb8
commit fa8009c6b7
11 changed files with 55 additions and 119 deletions

View File

@@ -50,13 +50,9 @@ class MatrixStorage
public:
MatrixStorage() {}
MatrixStorage(int dim) { EIGEN_UNUSED(dim); }
MatrixStorage(int) {}
MatrixStorage(int rows, int cols)
{
EIGEN_UNUSED(rows);
EIGEN_UNUSED(cols);
}
MatrixStorage(int, int) {}
~MatrixStorage() {};
};
@@ -92,9 +88,8 @@ class MatrixStorage<Scalar, Dynamic, ColsAtCompileTime>
m_array = new Scalar[m_rows * ColsAtCompileTime];
}
MatrixStorage(int rows, int cols) : m_rows(rows)
MatrixStorage(int rows, int) : m_rows(rows)
{
EIGEN_UNUSED(cols);
m_array = new Scalar[m_rows * ColsAtCompileTime];
}
@@ -136,9 +131,8 @@ class MatrixStorage<Scalar, RowsAtCompileTime, Dynamic>
m_array = new Scalar[m_cols * RowsAtCompileTime];
}
MatrixStorage(int rows, int cols) : m_cols(cols)
MatrixStorage(int, int cols) : m_cols(cols)
{
EIGEN_UNUSED(rows);
m_array = new Scalar[m_cols * RowsAtCompileTime];
}