devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix two perf issues in product.

Browse Source 
fix positive definite test in Cholesky.
remove #include <cstring> in CoreDeclaration.
This commit is contained in:
Gael Guennebaud
2008-08-03 20:23:06 +00:00
parent 49ae3fca89
commit f81dfcf00b
5 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Eigen/src/Cholesky/Cholesky.h
View File

@@ -96,7 +96,7 @@ void Cholesky<MatrixType>::compute(const MatrixType& a)
RealScalar x;
x = ei_real(a.coeff(0,0));
m_isPositiveDefinite = x > precision<Scalar>() && ei_isMuchSmallerThan(ei_imag(m_matrix.coeff(0,0)), RealScalar(1));
m_isPositiveDefinite = x > precision<Scalar>() && ei_isMuchSmallerThan(ei_imag(a.coeff(0,0)), RealScalar(1));
m_matrix.coeffRef(0,0) = ei_sqrt(x);
m_matrix.col(0).end(size-1) = a.row(0).end(size-1).adjoint() / ei_real(m_matrix.coeff(0,0));
for (int j = 1; j < size; ++j)
@@ -105,7 +105,7 @@ void Cholesky<MatrixType>::compute(const MatrixType& a)
x = ei_real(tmp);
if (x < precision<Scalar>() || (!ei_isMuchSmallerThan(ei_imag(tmp), RealScalar(1))))
{
m_isPositiveDefinite = m_isPositiveDefinite;
m_isPositiveDefinite = false;
return;
}
m_matrix.coeffRef(j,j) = x = ei_sqrt(x);
@@ -117,6 +117,7 @@ void Cholesky<MatrixType>::compute(const MatrixType& a)
m_matrix.col(j).end(endSize) =
(m_matrix.block(j+1, 0, endSize, j) * m_matrix.row(j).start(j).adjoint()).lazy();
// FIXME could use a.col instead of a.row
m_matrix.col(j).end(endSize) = (a.row(j).end(endSize).adjoint()
- m_matrix.col(j).end(endSize) ) / x;
}