devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix three more flaky tests: igamma, tensor_random, matrix_power

Browse Source 
libeigen/eigen!2268

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-03-08 16:00:04 -07:00
parent 8eaa7552fe
commit f80d7b8254
3 changed files with 34 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
unsupported/test/cxx11_tensor_random.cpp
View File

@@ -18,8 +18,19 @@ static void test_default() {
// Fixme: we should check that the generated numbers follow a uniform
// distribution instead.
for (int i = 1; i < 6; ++i) {
VERIFY_IS_NOT_EQUAL(vec(i), vec(i - 1));
// For low-precision types (half, bfloat16), the RNG has limited distinct
// values (e.g. 128 for bfloat16), so adjacent collisions are statistically
// inevitable. Only verify that not all values are identical.
if (sizeof(Scalar) <= 2) {
bool has_distinct = false;
for (int i = 1; i < 6 && !has_distinct; ++i) {
if (vec(i) != vec(i - 1)) has_distinct = true;
}
VERIFY(has_distinct);
} else {
for (int i = 1; i < 6; ++i) {
VERIFY_IS_NOT_EQUAL(vec(i), vec(i - 1));
}
}
}
@@ -30,8 +41,16 @@ static void test_normal() {
// Fixme: we should check that the generated numbers follow a gaussian
// distribution instead.
for (int i = 1; i < 6; ++i) {
VERIFY_IS_NOT_EQUAL(vec(i), vec(i - 1));
if (sizeof(Scalar) <= 2) {
bool has_distinct = false;
for (int i = 1; i < 6 && !has_distinct; ++i) {
if (vec(i) != vec(i - 1)) has_distinct = true;
}
VERIFY(has_distinct);
} else {
for (int i = 1; i < 6; ++i) {
VERIFY_IS_NOT_EQUAL(vec(i), vec(i - 1));
}
}
}