clean a bit previous patch (ctor vs static_cast and a few bits)

(transplanted from da644fb0c3e0b7fcda03ba27a02061c084809b9f)
This commit is contained in:
Gael Guennebaud
2011-05-23 13:34:04 +02:00
parent b3c3627c72
commit ee46ae9ba7
7 changed files with 24 additions and 21 deletions

View File

@@ -271,13 +271,13 @@ void real_2x2_jacobi_svd(const MatrixType& matrix, Index p, Index q,
RealScalar d = m.coeff(1,0) - m.coeff(0,1);
if(t == RealScalar(0))
{
rot1.c() = static_cast<RealScalar>(0);
rot1.s() = d > static_cast<RealScalar>(0) ? static_cast<RealScalar>(1) : static_cast<RealScalar>(-1);
rot1.c() = RealScalar(0);
rot1.s() = d > RealScalar(0) ? RealScalar(1) : RealScalar(-1);
}
else
{
RealScalar u = d / t;
rot1.c() = RealScalar(1) / sqrt(static_cast<RealScalar>(1) + abs2(u));
rot1.c() = RealScalar(1) / sqrt(RealScalar(1) + abs2(u));
rot1.s() = rot1.c() * u;
}
m.applyOnTheLeft(0,1,rot1);