devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix pexp_complex for complex<double> (issue #3022)

Browse Source 
libeigen/eigen!2140

Closes #3022

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-02-16 15:30:31 -08:00
parent 2b561f9284
commit e6e5b5c4c8
7 changed files with 51 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/packetmath.cpp
View File

@@ -1485,10 +1485,10 @@ struct exp_complex_test_impl {
}
// Verify equality with signed zero.
static bool is_exactly_equal(const Scalar& a, const Scalar& b) {
static bool is_exactly_equal(const Scalar& a, const Scalar& b, bool quiet = false) {
bool result = is_exactly_equal(numext::real_ref(a), numext::real_ref(b)) &&
is_exactly_equal(numext::imag_ref(a), numext::imag_ref(b));
if (!result) {
if (!result && !quiet) {
std::cout << a << " != " << b << std::endl;
}
return result;
@@ -1512,6 +1512,13 @@ struct exp_complex_test_impl {
if (numext::real_ref(z) == +inf && (numext::isnan)(numext::imag_ref(z))) {
return true;
}
// If exp(x) overflows to inf and y is finite nonzero, the result involves inf * cos(y) and
// inf * sin(y). When cos(y) or sin(y) is near a zero crossing (e.g., cos(pi/2)), different
// trig implementations may produce different signs, so the signs of the result are unspecified.
if (!(numext::isinf)(numext::imag_ref(z)) && !(numext::isnan)(numext::imag_ref(z)) && numext::imag_ref(z) != 0 &&
(numext::isinf)(std::exp(numext::real_ref(z)))) {
return true;
}
return false;
}
@@ -1558,7 +1565,12 @@ struct exp_complex_test_impl {
Scalar(numext::abs(numext::real_ref(expected)), numext::abs(numext::imag_ref(expected)));
VERIFY(is_exactly_equal(abs_w, abs_expected));
} else {
VERIFY(is_exactly_equal(w, numext::exp(z)));
Scalar expected = numext::exp(z);
// First try exact equality (handles NaN, signed zeros correctly).
// Fall back to approximate comparison to allow for small differences
// in trig functions near zero crossings (e.g., vectorized sincos may
// compute cos(pi/2) = 0 while scalar std::exp gives ~6.12e-17).
VERIFY(is_exactly_equal(w, expected, /*quiet=*/true) || verifyIsApprox(w, expected));
}
}
}