* rename QR to HouseholderQR because really that impacts the API, not just the impl.

* rename qr() to householderQr(), for same reason.
* clarify that it's non-pivoting, non-rank-revealing, so remove all the rank API, make solve() be void instead of bool, update the docs/test, etc.
* fix warning in SVD
This commit is contained in:
Benoit Jacob
2009-07-06 17:12:10 +02:00
parent 0c2232e5d9
commit e093b43b2c
9 changed files with 43 additions and 204 deletions

View File

@@ -241,8 +241,8 @@ void createRandomMatrixOfRank(int desired_rank, int rows, int cols, Eigen::Matri
const int diag_size = std::min(d.rows(),d.cols());
d.diagonal().segment(desired_rank, diag_size-desired_rank) = VectorType::Zero(diag_size-desired_rank);
QR<MatrixType> qra(a);
QR<MatrixType> qrb(b);
HouseholderQR<MatrixType> qra(a);
HouseholderQR<MatrixType> qrb(b);
m = (qra.matrixQ() * d * qrb.matrixQ()).lazy();
}