From e06c6553e00bbcd3f97663cbfeae3f2ce7f113fb Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Fri, 26 Nov 2010 15:36:29 +0100 Subject: [PATCH] make TridiagonalizationMatrixTReturnType internal and only export a public MatrixTReturnType typedef --- Eigen/src/Eigenvalues/Tridiagonalization.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/Eigen/src/Eigenvalues/Tridiagonalization.h b/Eigen/src/Eigenvalues/Tridiagonalization.h index b97710d61..1df2aedf7 100644 --- a/Eigen/src/Eigenvalues/Tridiagonalization.h +++ b/Eigen/src/Eigenvalues/Tridiagonalization.h @@ -26,17 +26,15 @@ #ifndef EIGEN_TRIDIAGONALIZATION_H #define EIGEN_TRIDIAGONALIZATION_H -template struct TridiagonalizationMatrixTReturnType; - namespace internal { + +template struct TridiagonalizationMatrixTReturnType; template struct traits > { typedef typename MatrixType::PlainObject ReturnType; }; -} -namespace internal { template void tridiagonalization_inplace(MatrixType& matA, CoeffVectorType& hCoeffs); } @@ -95,7 +93,7 @@ template class Tridiagonalization typedef Matrix CoeffVectorType; typedef typename internal::plain_col_type::type DiagonalType; typedef Matrix SubDiagonalType; - typedef typename internal::remove_all::type MatrixTypeRealView; + typedef internal::TridiagonalizationMatrixTReturnType MatrixTReturnType; typedef typename internal::conditional::IsComplex, typename Diagonal::RealReturnType, @@ -272,10 +270,10 @@ template class Tridiagonalization * \sa Tridiagonalization(const MatrixType&) for an example, * matrixQ(), packedMatrix(), diagonal(), subDiagonal() */ - TridiagonalizationMatrixTReturnType matrixT() const + MatrixTReturnType matrixT() const { eigen_assert(m_isInitialized && "Tridiagonalization is not initialized."); - return TridiagonalizationMatrixTReturnType(m_matrix.real()); + return MatrixTReturnType(m_matrix.real()); } /** \brief Returns the diagonal of the tridiagonal matrix T in the decomposition. @@ -525,10 +523,8 @@ struct tridiagonalization_inplace_selector } }; -} // end namespace internal - -/** \eigenvalues_module \ingroup Eigenvalues_Module - * +/** \internal + * \eigenvalues_module \ingroup Eigenvalues_Module * * \brief Expression type for return value of Tridiagonalization::matrixT() * @@ -561,4 +557,6 @@ template struct TridiagonalizationMatrixTReturnType const typename MatrixType::Nested m_matrix; }; +} // end namespace internal + #endif // EIGEN_TRIDIAGONALIZATION_H