devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix polynomialsolver test failures

Browse Source 
libeigen/eigen!2104
This commit is contained in:
Charles Schlosser
2026-01-05 05:19:49 +00:00
parent 711118b747
commit d90a0534be
2 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
unsupported/test/polynomialsolver.cpp
View File

@@ -131,28 +131,28 @@ void evalSolverSugarFunction(const POLYNOMIAL& pols, const ROOTS& roots, const R
bool hasRealRoot;
// Test absGreatestRealRoot
RealScalar r = psolve.absGreatestRealRoot(hasRealRoot);
RealScalar r = psolve.absGreatestRealRoot(hasRealRoot, test_precision<RealScalar>());
VERIFY(hasRealRoot == (real_roots.size() > 0));
if (hasRealRoot) {
VERIFY(internal::isApprox(real_roots.array().abs().maxCoeff(), abs(r), psPrec));
}
// Test absSmallestRealRoot
r = psolve.absSmallestRealRoot(hasRealRoot);
r = psolve.absSmallestRealRoot(hasRealRoot, test_precision<RealScalar>());
VERIFY(hasRealRoot == (real_roots.size() > 0));
if (hasRealRoot) {
VERIFY(internal::isApprox(real_roots.array().abs().minCoeff(), abs(r), psPrec));
}
// Test greatestRealRoot
r = psolve.greatestRealRoot(hasRealRoot);
r = psolve.greatestRealRoot(hasRealRoot, test_precision<RealScalar>());
VERIFY(hasRealRoot == (real_roots.size() > 0));
if (hasRealRoot) {
VERIFY(internal::isApprox(real_roots.array().maxCoeff(), r, psPrec));
}
// Test smallestRealRoot
r = psolve.smallestRealRoot(hasRealRoot);
r = psolve.smallestRealRoot(hasRealRoot, test_precision<RealScalar>());
VERIFY(hasRealRoot == (real_roots.size() > 0));
if (hasRealRoot) {
VERIFY(internal::isApprox(real_roots.array().minCoeff(), r, psPrec));
@@ -180,6 +180,9 @@ void polynomialsolver(int deg) {
cout << "Test sugar" << endl;
RealRootsType realRoots = RealRootsType::Random(deg);
// sort by ascending absolute value to mitigate precision lost during polynomial expansion
std::sort(realRoots.begin(), realRoots.end(),
[](RealScalar a, RealScalar b) { return numext::abs(a) < numext::abs(b); });
roots_to_monicPolynomial(realRoots, pols);
evalSolverSugarFunction<Deg_>(pols, realRoots.template cast<std::complex<RealScalar> >().eval(), realRoots);
}