devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Clean up informal language, vague TODOs, and dead code in comments

Browse Source 
libeigen/eigen!2191

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-02-22 18:32:10 -08:00
parent 7d727d26bc
commit d5e67adbe7
63 changed files with 136 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Eigen/src/IterativeLinearSolvers/IncompleteCholesky.h
View File

@@ -264,7 +264,7 @@ void IncompleteCholesky<Scalar, UpLo_, OrderingType>::factorize(const MatrixType
else
m_scale(j) = 1;
// TODO disable scaling if not needed, i.e., if it is roughly uniform? (this will make solve() faster)
// TODO: disable scaling when roughly uniform to speed up solve().
// Scale and compute the shift for the matrix
RealScalar mindiag = NumTraits<RealScalar>::highest();

4
Eigen/src/IterativeLinearSolvers/IncompleteLUT.h
View File

@@ -244,8 +244,8 @@ void IncompleteLUT<Scalar, StorageIndex>::analyzePattern(const MatrixType_& amat
// To this end, let's symmetrize the pattern and perform AMD on it.
SparseMatrix<Scalar, ColMajor, StorageIndex> mat1 = amat;
SparseMatrix<Scalar, ColMajor, StorageIndex> mat2 = amat.transpose();
// FIXME for a matrix with nearly symmetric pattern, mat2+mat1 is the appropriate choice.
// on the other hand for a really non-symmetric pattern, mat2*mat1 should be preferred...
// FIXME: for a nearly symmetric pattern, mat2+mat1 is appropriate;
// for a highly non-symmetric pattern, mat2*mat1 should be preferred.
SparseMatrix<Scalar, ColMajor, StorageIndex> AtA = mat2 + mat1;
AMDOrdering<StorageIndex> ordering;
ordering(AtA, m_P);