devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix use of rank in QR

Browse Source
This commit is contained in:
Gael Guennebaud
2010-07-15 19:59:21 +02:00
parent b09bb50aeb
commit ccc6731f86
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Eigen/src/QR/QR.h
View File

@@ -270,12 +270,15 @@ bool QR<MatrixType>::solve(
ei_assert(m_isInitialized && "QR is not initialized."); ei_assert(m_isInitialized && "QR is not initialized.");
const int rows = m_qr.rows(); const int rows = m_qr.rows();
ei_assert(b.rows() == rows); ei_assert(b.rows() == rows);
// enforce the computation of the rank
rank();
result->resize(m_qr.cols(), b.cols()); result->resize(m_qr.cols(), b.cols());
// TODO(keir): There is almost certainly a faster way to multiply by // TODO(keir): There is almost certainly a faster way to multiply by
// Q^T without explicitly forming matrixQ(). Investigate. // Q^T without explicitly forming matrixQ(). Investigate.
*result = matrixQ().transpose()*b; *result = matrixQ().transpose()*b;
if(m_rank==0) if(m_rank==0)
return result->isZero(); return result->isZero();