devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Half NaN definition and test.

Browse Source 
The `half_float` test was failing with `-mcpu=cortex-a55` (native `__fp16`) due
to a bad NaN bit-pattern comparison (in the case of casting a float to `__fp16`,
the signaling `NaN` is quieted). There was also an inconsistency between
`numeric_limits<half>::quiet_NaN()` and `NumTraits::quiet_NaN()`.  Here we
correct the inconsistency and compare NaNs according to the IEEE 754
definition.

Also modified the `bfloat16_float` test to match.

Tested with `cortex-a53` and `cortex-a55`.
This commit is contained in:
Rasmus Munk Larsen
2020-11-24 20:53:07 +00:00
parent 22f67b5958
commit c770746d70
8 changed files with 176 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
Eigen/src/Core/arch/Default/GenericPacketMathFunctions.h
View File

@@ -643,6 +643,62 @@ Packet pcos_float(const Packet& x)
return psincos_float<false>(x);
}
template<typename Packet>
EIGEN_DEFINE_FUNCTION_ALLOWING_MULTIPLE_DEFINITIONS
EIGEN_UNUSED
Packet psqrt_complex(const Packet& a) {
typedef typename unpacket_traits<Packet>::type Scalar;
typedef typename Scalar::value_type RealScalar;
typedef typename unpacket_traits<Packet>::real RealPacket;
// Computes the principal sqrt of the complex numbers. For clarity, the comments
// below spell out the steps, assuming Packet contains 2 complex numbers, e.g.
// a = [a0_r, a0_i, a1_r, a1_i]
// In other words, the function computes b = [b0_r, b0_i, b1_r, b1_i] such that
// (b0_r + i*b0_i)^2 = a0_r + i*a0_i, and
// (b1_r + i*b1_i)^2 = a1_r + i*a1_i .
// Step 1. Compute l = [l0, l0, l1, l1], where
// l0 = sqrt(a0_r^2 + a0_i^2), l1 = sqrt(a1_r^2 + a1_i^2)
// To avoid over- and underflow, we use the stable formula for each hypotenuse
// l0 = (x0 == 0 ? x0 : x0 * sqrt(1 + (y0/x0)**2)),
// where x0 = max(|a0_r|, |a0_i|), y0 = min(|a0_r|, |a0_i|)
// and similarly for l1.
Packet a_flip = pcplxflip(a);
Packet zero_mask;
zero_mask.v = pcmp_eq(a.v, pzero(a.v));
RealPacket a_abs = pabs(a.v); // [|a0_i|, |a0_r|, |a1_i|, |a1_r|]
RealPacket a_abs_flip = pabs(a_flip.v); // [|a0_i|, |a0_r|, |a1_i|, |a1_r|]
RealPacket a_max = pmax(a_abs, a_abs_flip);
RealPacket a_min = pmin(a_abs, a_abs_flip);
RealPacket r = pdiv(a_min, a_max);
RealPacket one = pset1<RealPacket>(RealScalar(1));
RealPacket l = pmul(a_max, psqrt(padd(one, pmul(r, r)))); // [l0, l0, l1, l1]
// Set l to zero if both real and imaginary parts are zero.
l = pandnot(l, pand(zero_mask.v, pcplxflip(zero_mask).v));
// Step 2. Compute
// [ sqrt((l0 + a0_r)/2), sqrt((l0 - a0_r)/2),
// sqrt((l1 + a1_r)/2), sqrt((l1 - a1_r)/2) ]
Packet real_mask;
real_mask.v = peven_mask(real_mask.v);
Packet a_real = pand(a, real_mask);
l = padd(l, a_real.v);
l = psub(l, pcplxflip(a_real).v);
l = psqrt(pmul(l, pset1<RealPacket>(RealScalar(0.5))));
// If imag(a) is zero, we mask out the imaginary part, which should be zero.
l = pandnot(l, pandnot(zero_mask.v, real_mask.v));
//Step 3. Apply the sign of the imaginary parts of a to get the final result:
// b = [ sqrt((l0 + a0_r)/2), sign(a0_i)*sqrt((l0 - a0_r)/2),
// sqrt((l1 + a1_r)/2), sign(a1_i)*sqrt((l1 - a1_r)/2) ]
RealPacket imag_sign_mask = pset1<Packet>(Scalar(RealScalar(0.0), RealScalar(-0.0))).v;
RealPacket imag_signs = pand<RealPacket>(a.v, imag_sign_mask);
Packet result = Packet(pxor<RealPacket>(l, imag_signs));
return result;
}
/* polevl (modified for Eigen)
*
* Evaluate polynomial