devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

updates based on PR feedback

Browse Source 
There are two major changes (and a few minor ones which are not listed here...see PR discussion for details)

1. Eigen::half implementations for HIP and CUDA have been merged.
This means that
- `CUDA/Half.h` and `HIP/hcc/Half.h` got merged to a new file `GPU/Half.h`
- `CUDA/PacketMathHalf.h` and `HIP/hcc/PacketMathHalf.h` got merged to a new file `GPU/PacketMathHalf.h`
- `CUDA/TypeCasting.h` and `HIP/hcc/TypeCasting.h` got merged to a new file `GPU/TypeCasting.h`

After this change the `HIP/hcc` directory only contains one file `math_constants.h`. That will go away too once that file becomes a part of the HIP install.

2. new macros EIGEN_GPUCC, EIGEN_GPU_COMPILE_PHASE and EIGEN_HAS_GPU_FP16 have been added and the code has been updated to use them where appropriate.
- `EIGEN_GPUCC` is the same as `(EIGEN_CUDACC || EIGEN_HIPCC)`
- `EIGEN_GPU_DEVICE_COMPILE` is the same as `(EIGEN_CUDA_ARCH || EIGEN_HIP_DEVICE_COMPILE)`
- `EIGEN_HAS_GPU_FP16` is the same as `(EIGEN_HAS_CUDA_FP16 or EIGEN_HAS_HIP_FP16)`
This commit is contained in:
Deven Desai
2018-06-14 10:21:54 -04:00
parent ba972fb6b4
commit b6cc0961b1
29 changed files with 425 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
unsupported/test/cxx11_tensor_hip.cu
View File

@@ -1222,9 +1222,8 @@ void test_cxx11_tensor_hip()
CALL_SUBTEST(test_hip_elementwise());
CALL_SUBTEST(test_hip_props());
CALL_SUBTEST(test_hip_reduction());
// FIXME : uncommenting following tests results in compile failure
// CALL_SUBTEST(test_hip_contraction<ColMajor>());
// CALL_SUBTEST(test_hip_contraction<RowMajor>());
CALL_SUBTEST(test_hip_contraction<ColMajor>());
CALL_SUBTEST(test_hip_contraction<RowMajor>());
CALL_SUBTEST(test_hip_convolution_1d<ColMajor>());
CALL_SUBTEST(test_hip_convolution_1d<RowMajor>());
CALL_SUBTEST(test_hip_convolution_inner_dim_col_major_1d());