From a76950bdab00e36ef7ad8a34e01fdd2e53594ec1 Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Fri, 12 Feb 2010 09:41:56 +0100 Subject: [PATCH] fix a couple of ICE with gcc 4.0.1 --- Eigen/src/Core/DenseStorageBase.h | 2 +- Eigen/src/Householder/Householder.h | 6 +++--- Eigen/src/LU/Determinant.h | 2 +- test/product_notemporary.cpp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Eigen/src/Core/DenseStorageBase.h b/Eigen/src/Core/DenseStorageBase.h index 7006e3a95..89903d0f6 100644 --- a/Eigen/src/Core/DenseStorageBase.h +++ b/Eigen/src/Core/DenseStorageBase.h @@ -62,7 +62,7 @@ class DenseStorageBase : public _Base typedef class Eigen::Map AlignedMapType; protected: - ei_matrix_storage m_storage; + ei_matrix_storage m_storage; public: enum { NeedsToAlign = (!(Options&DontAlign)) diff --git a/Eigen/src/Householder/Householder.h b/Eigen/src/Householder/Householder.h index cfd3935fc..d86e287fa 100644 --- a/Eigen/src/Householder/Householder.h +++ b/Eigen/src/Householder/Householder.h @@ -45,7 +45,7 @@ void makeTrivialHouseholder( template void MatrixBase::makeHouseholderInPlace(Scalar& tau, RealScalar& beta) { - VectorBlock::ret> essentialPart(derived(), 1, size()-1); + VectorBlock::ret> essentialPart(derived(), 1, size()-1); makeHouseholder(essentialPart, tau, beta); } @@ -99,7 +99,7 @@ void MatrixBase::applyHouseholderOnTheLeft( const Scalar& tau, Scalar* workspace) { - Map > tmp(workspace,cols()); + Map > tmp(workspace,cols()); Block bottom(derived(), 1, 0, rows()-1, cols()); tmp.noalias() = essential.adjoint() * bottom; tmp += this->row(0); @@ -114,7 +114,7 @@ void MatrixBase::applyHouseholderOnTheRight( const Scalar& tau, Scalar* workspace) { - Map > tmp(workspace,rows()); + Map > tmp(workspace,rows()); Block right(derived(), 0, 1, rows(), cols()-1); tmp.noalias() = right * essential.conjugate(); tmp += this->col(0); diff --git a/Eigen/src/LU/Determinant.h b/Eigen/src/LU/Determinant.h index bae01256e..fb6577f08 100644 --- a/Eigen/src/LU/Determinant.h +++ b/Eigen/src/LU/Determinant.h @@ -99,7 +99,7 @@ template inline typename ei_traits::Scalar MatrixBase::determinant() const { assert(rows() == cols()); - typedef typename ei_nested::type Nested; + typedef typename ei_nested::type Nested; Nested nested(derived()); return ei_determinant_impl::type>::run(nested); } diff --git a/test/product_notemporary.cpp b/test/product_notemporary.cpp index 332858851..9084cde6b 100644 --- a/test/product_notemporary.cpp +++ b/test/product_notemporary.cpp @@ -112,7 +112,7 @@ template void product_notemporary(const MatrixType& m) // Zero temporaries for lazy products ... VERIFY_EVALUATION_COUNT( Scalar tmp = 0; tmp += Scalar(RealScalar(1)) / (m3.transpose().lazyProduct(m3)).diagonal().sum(), 0 ); - // ... and even no temporary for even deeply (>=2) nested products + // ... and even no temporary for even deeply (>=2) nested products VERIFY_EVALUATION_COUNT( Scalar tmp = 0; tmp += Scalar(RealScalar(1)) / (m3.transpose() * m3).diagonal().sum(), 0 ); VERIFY_EVALUATION_COUNT( Scalar tmp = 0; tmp += Scalar(RealScalar(1)) / (m3.transpose() * m3).diagonal().array().abs().sum(), 0 );