devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix relative tolerance scaling by multiplying with RHS norm in BiCGSTAB

Browse Source 
libeigen/eigen!2118
This commit is contained in:
mehmet alper kuyumcu
2026-01-29 16:59:38 +00:00
committed by Antonio Sánchez
parent 26c242ab58
commit 93ff388841
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Eigen/src/IterativeLinearSolvers/BiCGSTAB.h
View File

@@ -34,7 +34,6 @@ bool bicgstab(const MatrixType& mat, const Rhs& rhs, Dest& x, const Precondition
typedef typename Dest::RealScalar RealScalar; typedef typename Dest::RealScalar RealScalar;
typedef typename Dest::Scalar Scalar; typedef typename Dest::Scalar Scalar;
typedef Matrix<Scalar, Dynamic, 1> VectorType; typedef Matrix<Scalar, Dynamic, 1> VectorType;
RealScalar tol = tol_error;
Index maxIters = iters; Index maxIters = iters;
Index n = mat.cols(); Index n = mat.cols();
@@ -48,6 +47,9 @@ bool bicgstab(const MatrixType& mat, const Rhs& rhs, Dest& x, const Precondition
x.setZero(); x.setZero();
return true; return true;
} }
RealScalar tol = tol_error * rhs_norm;
Scalar rho(1); Scalar rho(1);
Scalar alpha(0); Scalar alpha(0);
Scalar w(1); Scalar w(1);