devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix undefined behavior. When resizing a default-constructed SparseArray, we end up calling memcpy(ptr, 0, 0), which is technically UB and gets caught by static analysis.

Browse Source
This commit is contained in:
vanhoucke
2015-06-19 15:53:30 +00:00
parent e4ed2566d5
commit 8d4d85161e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Eigen/src/SparseCore/CompressedStorage.h
View File

@@ -208,8 +208,10 @@ class CompressedStorage
Index* newIndices = new Index[size]; Index* newIndices = new Index[size];
size_t copySize = (std::min)(size, m_size); size_t copySize = (std::min)(size, m_size);
// copy // copy
internal::smart_copy(m_values, m_values+copySize, newValues); if (copySize>0) {
internal::smart_copy(m_indices, m_indices+copySize, newIndices); internal::smart_copy(m_values, m_values+copySize, newValues);
internal::smart_copy(m_indices, m_indices+copySize, newIndices);
}
// delete old stuff // delete old stuff
delete[] m_values; delete[] m_values;
delete[] m_indices; delete[] m_indices;