devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix integer sanitizer issues in shifts and test ranges

Browse Source 
libeigen/eigen!2320

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-03-20 17:27:02 -07:00
parent 89621d1024
commit 8115b45e50
4 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/redux.cpp
View File

@@ -32,7 +32,7 @@ void matrixRedux(const MatrixType& m) {
m2.setRandom();
// Prevent overflows for integer types.
if (Eigen::NumTraits<Scalar>::IsInteger) {
Scalar kMaxVal = Scalar(10000);
Scalar kMaxVal = Scalar(8);
m1.array() = m1.array() - kMaxVal * (m1.array() / kMaxVal);
m2.array() = m2.array() - kMaxVal * (m2.array() / kMaxVal);
}
@@ -98,6 +98,11 @@ void vectorRedux(const VectorType& w) {
VectorType v = VectorType::Random(size);
VectorType v_for_prod = VectorType::Ones(size) + Scalar(0.2) * v; // see comment above declaration of m1_for_prod
if (Eigen::NumTraits<Scalar>::IsInteger) {
Scalar kMaxVal = Scalar(8);
v.array() = v.array() - kMaxVal * (v.array() / kMaxVal);
v_for_prod = VectorType::Ones(size) + Scalar(0.2) * v;
}
for (int i = 1; i < size; i++) {
Scalar s(0), p(1);