devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Comment cleanup v3: trailing ??, informal language, FIXME/TODO colons

Browse Source 
libeigen/eigen!2197

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-02-22 21:20:08 -08:00
parent 112c2324bd
commit 78b76986b7
57 changed files with 90 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Eigen/src/Core/functors/AssignmentFunctors.h
View File

@@ -140,7 +140,7 @@ template <typename Scalar>
struct swap_assign_op {
EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE void assignCoeff(Scalar& a, const Scalar& b) const {
#ifdef EIGEN_GPUCC
// FIXME is there some kind of cuda::swap?
// FIXME: check whether cuda::swap exists.
Scalar t = b;
const_cast<Scalar&>(b) = a;
a = t;

4
Eigen/src/Core/functors/BinaryFunctors.h
View File

@@ -55,7 +55,7 @@ struct functor_traits<scalar_sum_op<LhsScalar, RhsScalar>> {
Cost = (int(NumTraits<LhsScalar>::AddCost) + int(NumTraits<RhsScalar>::AddCost)) / 2, // rough estimate!
PacketAccess =
is_same<LhsScalar, RhsScalar>::value && packet_traits<LhsScalar>::HasAdd && packet_traits<RhsScalar>::HasAdd
// TODO vectorize mixed sum
// TODO: vectorize mixed sum
};
};
@@ -94,7 +94,7 @@ struct functor_traits<scalar_product_op<LhsScalar, RhsScalar>> {
Cost = (int(NumTraits<LhsScalar>::MulCost) + int(NumTraits<RhsScalar>::MulCost)) / 2, // rough estimate!
PacketAccess =
is_same<LhsScalar, RhsScalar>::value && packet_traits<LhsScalar>::HasMul && packet_traits<RhsScalar>::HasMul
// TODO vectorize mixed product
// TODO: vectorize mixed product
};
};

6
Eigen/src/Core/functors/UnaryFunctors.h
View File

@@ -367,7 +367,7 @@ template <typename Scalar>
struct functor_traits<scalar_exp2_op<Scalar>> {
enum {
PacketAccess = packet_traits<Scalar>::HasExp,
Cost = functor_traits<scalar_exp_op<Scalar>>::Cost // TODO measure cost of exp2
Cost = functor_traits<scalar_exp_op<Scalar>>::Cost // TODO: measure cost of exp2
};
};
@@ -389,7 +389,7 @@ template <typename Scalar>
struct functor_traits<scalar_expm1_op<Scalar>> {
enum {
PacketAccess = packet_traits<Scalar>::HasExpm1,
Cost = functor_traits<scalar_exp_op<Scalar>>::Cost // TODO measure cost of expm1
Cost = functor_traits<scalar_exp_op<Scalar>>::Cost // TODO: measure cost of expm1
};
};
@@ -443,7 +443,7 @@ template <typename Scalar>
struct functor_traits<scalar_log1p_op<Scalar>> {
enum {
PacketAccess = packet_traits<Scalar>::HasLog1p,
Cost = functor_traits<scalar_log_op<Scalar>>::Cost // TODO measure cost of log1p
Cost = functor_traits<scalar_log_op<Scalar>>::Cost // TODO: measure cost of log1p
};
};