devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add more tests for pow and fix a corner case for huge exponent where the result is always zero or infinite unless x is one.

Browse Source
This commit is contained in:
Rasmus Munk Larsen
2021-02-05 16:58:49 -08:00
parent abcde69a79
commit 6e3b795f81
2 changed files with 32 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/array_cwise.cpp
View File

@@ -15,18 +15,31 @@ template<typename Scalar>
void pow_test() {
const Scalar zero = Scalar(0);
const Scalar one = Scalar(1);
const Scalar two = Scalar(2);
const Scalar three = Scalar(3);
const Scalar sqrt_half = Scalar(std::sqrt(0.5));
const Scalar sqrt2 = Scalar(std::sqrt(2));
const Scalar inf = std::numeric_limits<Scalar>::infinity();
const Scalar nan = std::numeric_limits<Scalar>::quiet_NaN();
const static Scalar abs_vals[] = {zero, sqrt_half, one, sqrt2, inf, nan};
const int abs_cases = 6;
const Scalar min = (std::numeric_limits<Scalar>::min)();
const Scalar max = (std::numeric_limits<Scalar>::max)();
const static Scalar abs_vals[] = {zero,
sqrt_half,
one,
sqrt2,
two,
three,
min,
max,
inf,
nan};
const int abs_cases = 10;
const int num_cases = 2*abs_cases * 2*abs_cases;
// Repeat the same value to make sure we hit the vectorized path.
const int num_repeats = 32;
Array<Scalar, Dynamic, Dynamic> x(num_repeats, num_cases);
Array<Scalar, Dynamic, Dynamic> y(num_repeats, num_cases);
Array<Scalar, Dynamic, Dynamic> expected(num_repeats, num_cases);
int count = 0;
for (int i = 0; i < abs_cases; ++i) {
const Scalar abs_x = abs_vals[i];
@@ -39,7 +52,6 @@ void pow_test() {
for (int repeat = 0; repeat < num_repeats; ++repeat) {
x(repeat, count) = x_case;
y(repeat, count) = y_case;
expected(repeat, count) = numext::pow(x_case, y_case);
}
++count;
}
@@ -52,8 +64,11 @@ void pow_test() {
bool all_pass = true;
for (int i = 0; i < 1; ++i) {
for (int j = 0; j < num_cases; ++j) {
// TODO(rmlarsen): Skip tests that trigger a known bug in pldexp for now.
if (std::abs(x(i,j)) == max || std::abs(x(i,j)) == min) continue;
Scalar e = numext::pow(x(i,j), y(i,j));
Scalar a = actual(i, j);
Scalar e = expected(i, j);
bool fail = !(a==e) && !internal::isApprox(a, e, tol) && !((numext::isnan)(a) && (numext::isnan)(e));
all_pass &= !fail;
if (fail) {