devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix remaining MSVC warnings in Windows CI (C4804, C4244, C4146, C4305)

Browse Source 
libeigen/eigen!2374

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-04-01 17:20:31 -07:00
parent 6a07970d7d
commit 64885cc6a3
7 changed files with 48 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/packetmath.cpp
View File

@@ -721,6 +721,11 @@ void packetmath() {
}
}
// C4804: unsafe use of type 'bool' in operation. Unavoidable when Scalar=bool.
#if EIGEN_COMP_MSVC
#pragma warning(push)
#pragma warning(disable : 4804)
#endif
ref[0] = Scalar(0);
for (int i = 0; i < PacketSize; ++i) ref[0] += data1[i];
VERIFY(test::isApproxAbs(ref[0], internal::predux(internal::pload<Packet>(data1)), refvalue) && "internal::predux");
@@ -732,6 +737,9 @@ void packetmath() {
internal::pstore(data2, internal::predux_half(internal::pload<Packet>(data1)));
VERIFY(test::areApprox(ref, data2, HalfPacketSize) && "internal::predux_half");
}
#if EIGEN_COMP_MSVC
#pragma warning(pop)
#endif
// Avoid overflows.
if (NumTraits<Scalar>::IsInteger && NumTraits<Scalar>::IsSigned &&