Remove random retry loops in tests (batch 3: geometry, sparse, umeyama)

libeigen/eigen!2262

Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
This commit is contained in:
Rasmus Munk Larsen
2026-03-09 00:35:26 -07:00
parent a3cb1c6591
commit 54458cb39d
3 changed files with 15 additions and 54 deletions

View File

@@ -223,13 +223,10 @@ void transformations() {
t4 *= aa3;
VERIFY_IS_APPROX(t3.matrix(), t4.matrix());
{
int guard = 0;
do {
v3 = Vector3::Random();
dont_over_optimize(v3);
} while (v3.cwiseAbs().minCoeff() < NumTraits<Scalar>::epsilon() && (++guard) < 100);
VERIFY(guard < 100);
v3 = Vector3::Random();
dont_over_optimize(v3);
for (int k = 0; k < 3; ++k) {
if (numext::abs(v3(k)) < NumTraits<Scalar>::epsilon()) v3(k) = NumTraits<Scalar>::epsilon();
}
Translation3 tv3(v3);
Transform3 t5(tv3);
@@ -384,13 +381,8 @@ void transformations() {
// test transform inversion
t0.setIdentity();
t0.translate(v0);
{
int guard = 0;
do {
t0.linear().setRandom();
} while (t0.linear().jacobiSvd().singularValues()(2) < test_precision<Scalar>() && (++guard) < 100);
VERIFY(guard < 100);
}
t0.linear().setRandom();
if (t0.linear().jacobiSvd().singularValues()(2) < test_precision<Scalar>()) t0.linear().setIdentity();
Matrix4 t044 = Matrix4::Zero();
t044(3, 3) = 1;
t044.block(0, 0, t0.matrix().rows(), 4) = t0.matrix();