devtools/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2026-04-10 11:34:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix big bug in loop unrolling

Browse Source
This commit is contained in:
Benoit Jacob
2007-10-10 06:33:09 +00:00
parent 06e1e0d83b
commit 3c98677376
3 changed files with 14 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Core/Trace.h
View File

@@ -30,12 +30,8 @@ template<int Index, int Rows, typename Derived> struct EiTraceUnroller
{
static void run(const Derived &mat, typename Derived::Scalar &trace)
{
const int i = Index - 1;
EiTraceUnroller<Index-1, Rows, Derived>::run(mat, trace);
if(i == Rows - 1)
trace = mat(i, i);
else
trace += mat(i, i);
trace += mat(Index, Index);
}
};
@@ -43,12 +39,11 @@ template<int Rows, typename Derived> struct EiTraceUnroller<0, Rows, Derived>
{
static void run(const Derived &mat, typename Derived::Scalar &trace)
{
EI_UNUSED(mat);
EI_UNUSED(trace);
trace = mat(0, 0);
}
};
template<int Rows, typename Derived> struct EiTraceUnroller<EiDynamic, Rows, Derived>
template<int Index, typename Derived> struct EiTraceUnroller<Index, EiDynamic, Derived>
{
static void run(const Derived &mat, typename Derived::Scalar &trace)
{
@@ -63,7 +58,7 @@ Scalar EiObject<Scalar, Derived>::trace() const
assert(rows() == cols());
Scalar res;
if(RowsAtCompileTime != EiDynamic && RowsAtCompileTime <= 16)
EiTraceUnroller<RowsAtCompileTime, RowsAtCompileTime, Derived>
EiTraceUnroller<RowsAtCompileTime-1, RowsAtCompileTime, Derived>
::run(*static_cast<const Derived*>(this), res);
else
{