lots more EIGEN2_SUPPORT fixes. Now several of the most important core tests build and succeed.

Eigen/src/Core/Flagged.h

@@ -55,6 +55,7 @@ template<typename ExpressionType, unsigned int Added, unsigned int Removed> clas
   public:
 
     typedef MatrixBase<Flagged> Base;
+    
     EIGEN_DENSE_PUBLIC_INTERFACE(Flagged)
     typedef typename internal::conditional<internal::must_nest_by_value<ExpressionType>::ret,
         ExpressionType, const ExpressionType&>::type ExpressionTypeNested;
@@ -67,21 +68,31 @@ template<typename ExpressionType, unsigned int Added, unsigned int Removed> clas
     inline Index outerStride() const { return m_matrix.outerStride(); }
     inline Index innerStride() const { return m_matrix.innerStride(); }
 
-    inline const Scalar coeff(Index row, Index col) const
+    inline CoeffReturnType coeff(Index row, Index col) const
     {
       return m_matrix.coeff(row, col);
     }
 
+    inline CoeffReturnType coeff(Index index) const
+    {
+      return m_matrix.coeff(index);
+    }
+    
+    inline const Scalar& coeffRef(Index row, Index col) const
+    {
+      return m_matrix.const_cast_derived().coeffRef(row, col);
+    }
+
+    inline const Scalar& coeffRef(Index index) const
+    {
+      return m_matrix.const_cast_derived().coeffRef(index);
+    }
+
     inline Scalar& coeffRef(Index row, Index col)
     {
       return m_matrix.const_cast_derived().coeffRef(row, col);
     }
 
-    inline const Scalar coeff(Index index) const
-    {
-      return m_matrix.coeff(index);
-    }
-
     inline Scalar& coeffRef(Index index)
     {
       return m_matrix.const_cast_derived().coeffRef(index);

Eigen/src/Core/Functors.h

@@ -82,16 +82,27 @@ struct functor_traits<scalar_product_op<LhsScalar,RhsScalar> > {
 /** \internal
   * \brief Template functor to compute the conjugate product of two scalars
   *
-  * This is a short cut for conj(x) * y which is needed for optimization purpose
+  * This is a short cut for conj(x) * y which is needed for optimization purpose; in Eigen2 support mode, this becomes x * conj(y)
   */
 template<typename Scalar> struct scalar_conj_product_op {
-  enum { Conj = NumTraits<Scalar>::IsComplex };
+
+  enum {
+    Conj = NumTraits<Scalar>::IsComplex,
+    #ifdef EIGEN2_SUPPORT // in Eigen2, dot product is linear in the first variable
+      LhsConj = false,
+      RhsConj = Conj
+    #else // in Eigen3, dot product is linear in the second variable
+      LhsConj = Conj,
+      RhsConj = false
+    #endif
+  };
+  
   EIGEN_EMPTY_STRUCT_CTOR(scalar_conj_product_op)
   EIGEN_STRONG_INLINE const Scalar operator() (const Scalar& a, const Scalar& b) const
-  { return conj_helper<Scalar,Scalar,Conj,false>().pmul(a,b); }
+  { return conj_helper<Scalar,Scalar,LhsConj,RhsConj>().pmul(a,b); }
   template<typename Packet>
   EIGEN_STRONG_INLINE const Packet packetOp(const Packet& a, const Packet& b) const
-  { return conj_helper<Packet,Packet,Conj,false>().pmul(a,b); }
+  { return conj_helper<Packet,Packet,LhsConj,RhsConj>().pmul(a,b); }
 };
 template<typename Scalar>
 struct functor_traits<scalar_conj_product_op<Scalar> > {

Eigen/src/Core/NumTraits.h

@@ -69,12 +69,6 @@ template<typename T> struct GenericNumTraits
     AddCost = 1,
     MulCost = 1
   };
-  
-#ifdef EIGEN2_SUPPORT
-  enum {
-    HasFloatingPoint = !IsInteger
-  };
-#endif
 
   typedef T Real;
   typedef typename internal::conditional<
@@ -92,6 +86,13 @@ template<typename T> struct GenericNumTraits
   }
   inline static T highest() { return std::numeric_limits<T>::max(); }
   inline static T lowest()  { return IsInteger ? std::numeric_limits<T>::min() : (-std::numeric_limits<T>::max()); }
+  
+#ifdef EIGEN2_SUPPORT
+  enum {
+    HasFloatingPoint = !IsInteger
+  };
+  typedef NonInteger FloatingPoint;
+#endif
 };
 
 template<typename T> struct NumTraits : GenericNumTraits<T>

Eigen/src/Core/ProductBase.h

@@ -145,9 +145,13 @@ class ProductBase : public MatrixBase<Derived>
     // restrict coeff accessors to 1x1 expressions. No need to care about mutators here since this isnt a Lvalue expression
     typename Base::CoeffReturnType coeff(Index row, Index col) const
     {
+#ifdef EIGEN2_SUPPORT
+      return lhs().row(row).cwiseProduct(rhs().col(col).transpose()).sum();
+#else
       EIGEN_STATIC_ASSERT_SIZE_1x1(Derived)
       eigen_assert(this->rows() == 1 && this->cols() == 1);
       return derived().coeff(row,col);
+#endif
     }
 
     typename Base::CoeffReturnType coeff(Index i) const

Eigen/src/Core/util/StaticAssert.h

@@ -171,8 +171,14 @@
        ) \
      )
 
-#define EIGEN_STATIC_ASSERT_NON_INTEGER(TYPE) \
-  EIGEN_STATIC_ASSERT(!NumTraits<TYPE>::IsInteger, THIS_FUNCTION_IS_NOT_FOR_INTEGER_NUMERIC_TYPES)
+#ifdef EIGEN2_SUPPORT
+  #define EIGEN_STATIC_ASSERT_NON_INTEGER(TYPE) \
+    eigen_assert(!NumTraits<Scalar>::IsInteger);
+#else
+  #define EIGEN_STATIC_ASSERT_NON_INTEGER(TYPE) \
+    EIGEN_STATIC_ASSERT(!NumTraits<TYPE>::IsInteger, THIS_FUNCTION_IS_NOT_FOR_INTEGER_NUMERIC_TYPES)
+#endif
+
 
 // static assertion failing if it is guaranteed at compile-time that the two matrix expression types have different sizes
 #define EIGEN_STATIC_ASSERT_SAME_MATRIX_SIZE(TYPE0,TYPE1) \