mirror of
https://gitlab.com/libeigen/eigen.git
synced 2026-04-10 11:34:33 +08:00
Replace memset with fill to work for non-trivial scalars.
For custom scalars, zero is not necessarily represented by a zeroed-out memory block (e.g. gnu MPFR). We therefore cannot rely on `memset` if we want to fill a matrix or tensor with zeroes. Instead, we should rely on `fill`, which for trivial types does end up getting converted to a `memset` under-the-hood (at least with gcc/clang). Requires adding a `fill(begin, end, v)` to `TensorDevice`. Replaced all potentially bad instances of memset with fill. Fixes #2245.
This commit is contained in:
committed by
Rasmus Munk Larsen
parent
e9c9a3130b
commit
1e6c6c1576
@@ -912,9 +912,9 @@ struct TensorEvaluator<const TensorContractionOp<Indices, LeftArgType, RightArgT
|
||||
// On 10000x2x10000 mm zeroing can easily take half of time. Zero (bn
|
||||
// x m) row. Safe to do here because all kernels that will write to
|
||||
// this memory depend on completion of this task. Note: don't call
|
||||
// device_.memset() here. device_.memset() blocks on thread pool
|
||||
// device_.fill() here. device_.fill() blocks on thread pool
|
||||
// worker thread, which can lead to underutilization and deadlocks.
|
||||
memset(buffer_ + n1 * bn_ * m_, 0, bn(n1) * m_ * sizeof(Scalar));
|
||||
std::fill_n(buffer_ + n1 * bn_ * m_, bn(n1) * m_, Scalar(0));
|
||||
}
|
||||
kernel_.packRhs(&packed_rhs(n, k, n1, use_thread_local),
|
||||
rhs_.getSubMapper(k * bk_, n1 * bn_), bk(k), bn(n1));
|
||||
|
||||
Reference in New Issue
Block a user